fix(marketx): restore orphaned safety tests and harden CI - #275
Merged
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the orphaned MarketX source files and restores the 13 fee/volume safety tests that were previously invisible to the Rust toolchain.
This PR also removes stale duplicate sources and strengthens CI so orphaned Rust files and coverage regressions cannot silently pass again.
Changes
test_integer_safety.rsandtest_volume.rsintolib.rs.ContractErrordocumentation fromtarpaulin.rsinto the liveerrors.rs.tarpaulin.rs.Automation.rs..rsfiles under contractsrc/directories that are not reachable from their crate module tree.Validation
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo test--fail-underthresholdResult
The previously unreachable MarketX safety tests are now compiled and executed as part of the normal test suite, while CI now prevents similar dead source files and coverage regressions from going unnoticed.
Closes #272